Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake:synchronize settings of CMake Toolchain file and redefine syms #12150

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xuxin930
Copy link
Contributor

@xuxin930 xuxin930 commented Apr 15, 2024

Summary

  1. synchronize settings of CMake Toolchain file
  2. synchronize the settings of sim redefine symbols

Impact

link to: #12127

Testing

CI build

Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add commit message describing the issue fixed and the change

@xuxin930 xuxin930 marked this pull request as draft April 17, 2024 01:47
endif()

# Link Time Optimization

if(CONFIG_LTO_THIN)
add_compile_options(-flto=thin)
if(CONFIG_ARM_TOOLCHAIN_ARMCLANG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified the ac6 compiler? If not, please remove all CONFIG_ARM_TOOLCHAIN_ARMCLANG logic in cmake.

Copy link
Contributor Author

@xuxin930 xuxin930 Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified the ac6 compiler? If not, please remove all CONFIG_ARM_TOOLCHAIN_ARMCLANG logic in cmake.

Okay, I don’t have a license, I’ll remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get access to the compiler as part of Arm Development Studio, which has a free 30 day evaluation license available for freelance developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants