Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13184 - on ProcessGroup.start(), mark invalid processors to start once they become valid #8809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greyp9
Copy link
Contributor

@greyp9 greyp9 commented May 10, 2024

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@joewitt
Copy link
Contributor

joewitt commented May 10, 2024

@greyp9 Can you clarify the behavior you're seeing. I have a system i can try to reproduce this on but I have some python components that take some time to load and they show up invalid. But they did start on their own I thought.

Are you saying right now such components even if set to auto start would on restart not launch?

@greyp9
Copy link
Contributor Author

greyp9 commented May 10, 2024

app1.log

This is a log excerpt (grep processor ID) that illustrates the updated behavior.

@greyp9
Copy link
Contributor Author

greyp9 commented May 10, 2024

I've not tested the case where the processors are set to auto-start.

In the case where a flow is imported, during the period of time where the dependencies are being resolved, the action "ProcessGroup / Start" excludes the processors with dependencies. So they end up Stopped, even after the dependencies become available.

@greyp9
Copy link
Contributor Author

greyp9 commented May 10, 2024

I suspect that, if set to auto-start in the flow definition, things would work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants