Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13138 - Add extensions name and description in NiFi Registry #8740

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-13138 - Add extensions name and description in NiFi Registry

Screenshot 2024-05-03 at 18 25 27
Screenshot 2024-05-03 at 18 25 16
Screenshot 2024-05-03 at 18 25 06

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement to the Registry extension details @pvillard31. The general approach looks straightforward. The only potential concern is that the sections for Processors, Controller Services, and Reporting Tasks will be empty depending on what is contained in the given bundle. It seems like it would be better to list only those sections that apply to the given bundle. Another alternative could be to have the number of components listed next to the section, such as Processors: 0, which would support showing the sections in all cases, but more clearly indicating the presence of absence of items for that section.

@pvillard31
Copy link
Contributor Author

Thanks @exceptionfactory - added the number of components per type

Screenshot 2024-05-15 at 23 51 56
Screenshot 2024-05-15 at 23 51 51

@pvillard31
Copy link
Contributor Author

@exceptionfactory - I will update this PR to also include Parameter Providers and Flow Analysis Rules. Is there something else you'd expect to see here?

@exceptionfactory
Copy link
Contributor

@exceptionfactory - I will update this PR to also include Parameter Providers and Flow Analysis Rules. Is there something else you'd expect to see here?

Thanks @pvillard31, I was planning on circling back to this, so if you can add those items, I think it should be ready to merge.

@pvillard31
Copy link
Contributor Author

Done, thanks @exceptionfactory

Screenshot 2024-05-31 at 19 27 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants