NIFI-12973 Add Process Group scope to Flow Analysis rules

[tpalfy]

Summary

NIFI-12973

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[pvillard31]

@tpalfy - not sure if/why this is related to this PR but the system tests seem to be failing consistently

Error:  Errors: 
Error:    PythonNarIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi
Error:    PythonProcessorIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi
Error:    PythonProcessorIT>NiFiSystemIT.setup:122 » Runtime Failed to start NiFi

I've been rerunning the tests a few times already but no change.

[joewitt]

@pvillard31 What command are you running to have the Python tests fail?

Consistent with what we run on github CI I use

mvn verify -Pintegration-tests,integration-tests-ci,skip-unit-tests -pl -:minifi-assembly -pl -:nifi-assembly -pl -:nifi-toolkit-assembly -pl -:nifi-registry-assembly -pl -:nifi-registry-toolkit-assembly -pl -:nifi-runtime-manifest -pl -:nifi-runtime-manifest-test -pl -:nifi-stateless-assembly -pl -:nifi-stateless-system-test-suite -pl -:nifi-system-test-suite -pl -:nifi-nar-provider-assembly -pl -:nifi-py4j-integration-tests -pl -:nifi-docs -pl -:nifi-maven-archetypes -pl -:nifi-processor-bundle-archetype -pl -:nifi-service-bundle-archetype

But notably that skips py4j-integration-tests. I'll run that locally and see what fun comes out

[joewitt]

@pvillard31 disregard. I'll have a pull request up for for NIFI-13139 that should address that problem. I think you can ignore that for this PR about flow analysis

[joewitt]

Re-opening as per comments on the JIRA.

[exceptionfactory]

For tracking purposes, I have flagged the implementation issue with parsing and storage of Process Group identifiers that I also mentioned on the Jira issue. The usability concerns also need to be addressed.

[exceptionfactory]

As noted on the Jira issue, this approach should be refactored to avoid splitting during rule evaluation and instead storing the values as a List of strings.