Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12801 Add local file upload option in PutHDFS processor #8415

Closed
wants to merge 1 commit into from

Conversation

shubhluck
Copy link
Contributor

Summary

NIFI-12801

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@Lehel44 Lehel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shubhluck for adding this feature. I tested it manually with local hadoop setup. LGTM+1

Copy link
Contributor

@Lehel44 Lehel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhluck There are pipeline failures because of ststic analysis check. There are unused imports and wildcard * imports in PutHDFSTest. In case you use Intellij IDEA you can turn itt off here. Run the build with -Pcontrib-check to run the static code analysis. As soon as the pipeline is fixed I will approve it.

@shubhluck
Copy link
Contributor Author

Thank you @Lehel44 for reviewing and testing, I've fixed unused imports and wildcard imports.

@shubhluck
Copy link
Contributor Author

Hello @Lehel44 thank you again for reviewing the changes, please find the above test cases are passed and good to go for merge.

@shubhluck shubhluck requested a review from Lehel44 April 17, 2024 06:36
Copy link
Contributor

@Lehel44 Lehel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. Thanks for making the changes. Looks good to me!

@turcsanyip
Copy link
Contributor

@shubhluck Thanks for your first contribution!
There have been changes on the main branch since you opened this PR. Could you please rebase your branch onto the current main, resolve the conflicts and then force push the branch?
Thanks

@shubhluck
Copy link
Contributor Author

Thank you @turcsanyip for review let me quickly complete your suggested changes and rebasing with main branch.

@shubhluck shubhluck force-pushed the NIFI-12801 branch 2 times, most recently from b8a10aa to ba554cc Compare June 1, 2024 02:06
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shubhluck!
Thanks @Lehel44 for you review!

+1 merging

@asfgit asfgit closed this in a21c254 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants