Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultValue for all boolean Mojo parameters defaulting to false #219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add defaultValue for all boolean Mojo parameters defaulting to false #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30bad3
Add `defaultValue` for all boolean Mojo parameters
Marcono1234 Apr 5, 2024
08c4611
Revert change to `finalName` documentation.
Marcono1234 Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,10 @@ public class ShadeMojo extends AbstractMojo {
private String shadedGroupFilter;

/**
* Defines whether the shaded artifact should be attached as classifier to the original artifact. If false, the
* shaded jar will be the main artifact of the project
* Defines whether the shaded artifact should be attached as classifier to the original artifact. If false (the
* default), the shaded jar will be the main artifact of the project.
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean shadedArtifactAttached;

/**
Expand Down Expand Up @@ -265,14 +265,14 @@ public class ShadeMojo extends AbstractMojo {
/**
* When true, dependencies are kept in the pom but with scope 'provided'; when false, the dependency is removed.
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean keepDependenciesWithProvidedScope;

/**
* When true, transitive deps of removed dependencies are promoted to direct dependencies. This should allow the
* drop in replacement of the removed deps with the new shaded jar and everything should still work.
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean promoteTransitiveDependencies;

/**
Expand All @@ -284,13 +284,13 @@ public class ShadeMojo extends AbstractMojo {
/**
* When true, it will attempt to create a sources jar as well
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean createSourcesJar;

/**
* When true, it will attempt to create a test sources jar.
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean createTestSourcesJar;

/**
Expand Down Expand Up @@ -321,7 +321,7 @@ public class ShadeMojo extends AbstractMojo {
*
* @since 1.4
*/
@Parameter
@Parameter(defaultValue = "false")
private boolean minimizeJar;

/**
Expand Down