Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary bit conversion for IndexSorter #13320

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove unnecessary bit conversion for IndexSorter #13320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 9 additions & 22 deletions lucene/core/src/java/org/apache/lucene/index/IndexSorter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,23 +266,16 @@ public FloatSorter(
public ComparableProvider[] getComparableProviders(List<? extends LeafReader> readers)
throws IOException {
ComparableProvider[] providers = new ComparableProvider[readers.size()];
final float missingValue;
if (this.missingValue != null) {
missingValue = this.missingValue;
} else {
missingValue = 0.0f;
}
final int missValueBits = Float.floatToIntBits(missingValue != null ? missingValue : 0.0f);

for (int readerIndex = 0; readerIndex < readers.size(); readerIndex++) {
final NumericDocValues values = valuesProvider.get(readers.get(readerIndex));

providers[readerIndex] =
docID -> {
float value = missingValue;
if (values.advanceExact(docID)) {
value = Float.intBitsToFloat((int) values.longValue());
}
return NumericUtils.floatToSortableInt(value);
final int valueBits =
values.advanceExact(docID) ? (int) values.longValue() : missValueBits;
return NumericUtils.sortableFloatBits(valueBits);
};
}
return providers;
Expand Down Expand Up @@ -336,23 +329,17 @@ public DoubleSorter(
public ComparableProvider[] getComparableProviders(List<? extends LeafReader> readers)
throws IOException {
ComparableProvider[] providers = new ComparableProvider[readers.size()];
final double missingValue;
if (this.missingValue != null) {
missingValue = this.missingValue;
} else {
missingValue = 0.0f;
}
final long missingValueBits =
Double.doubleToLongBits(missingValue != null ? missingValue : 0.0f);

for (int readerIndex = 0; readerIndex < readers.size(); readerIndex++) {
final NumericDocValues values = valuesProvider.get(readers.get(readerIndex));

providers[readerIndex] =
docID -> {
double value = missingValue;
if (values.advanceExact(docID)) {
value = Double.longBitsToDouble(values.longValue());
}
return NumericUtils.doubleToSortableLong(value);
final long valueBits =
values.advanceExact(docID) ? values.longValue() : missingValueBits;
return NumericUtils.sortableDoubleBits(valueBits);
};
}
return providers;
Expand Down