Align toString methods in geo module #13302
Merged
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slow-J
reviewed
Apr 17, 2024
| @@ -187,6 +187,7 @@ public boolean equals(Object obj) { | |||
| @Override | |||
| public String toString() { | |||
| StringBuilder sb = new StringBuilder(); | |||
| sb.append("XYPolygon"); | |||
There was a problem hiding this comment.
While were doing this standardization, can we also add the name to the others that are missing it too? Like Polygon
There was a problem hiding this comment.
Good point! Added it to Polygon, too.
slow-J
approved these changes
Apr 23, 2024
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some
toStringmethods in thegeomodule sometimes use uppercase or the class name. I've aligned them to use always the class name.