Add 'passageSortComparator' option in FieldHighlighter #13276
Merged
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
I like this change; very nice! I shall merge it. Please share how I shall list you in CHANGES.txt. Proposed text under improvements to 9.11:
|
Seunghan-Jung
force-pushed
the
passageSortComparator_option_in_FieldHighlighter
branch
from
1581e2b
to
bf6eb2d
Compare
Seunghan-Jung
commented
May 23, 2024
dsmiley
approved these changes
May 23, 2024
dsmiley
pushed a commit
that referenced
this pull request
May 24, 2024
new 'passageSortComparator' option to allow sorting other than offset order (cherry picked from commit 8773725)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FieldHighlighteralways sorts the final selected passages based on startOffset, but this may not align with the user's intentions.For example, in the case of Solr's multiValue fields, the order might just be a simple listing of items without any significance. In such cases, the order in which passages appear is not important. It might be more effective to maintain sorting by score in these situations.
Therefore, it seems necessary to allow for the final sorting criteria to be determined in accordance with the user's intentions.