update commons-compress from 1.19 to 1.21 #13270
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another pre-covid dependency version...
I tried to upgrade to the latest version (both with and without the entangled commons-codec upgrade: #13269) and there is trouble everywhere.
Newer versions of this library just drag in more and more dependencies and have more jar/module hell and larger surface area. For example they are dragging in JNI compressors etc!
https://commons.apache.org/proper/commons-compress/dependencies.html
For now, I'd like to just upgrade these two minor versions to get us "less ancient", but going forwards I think we need to evaluate if we should really have a dependency mess just to support
bzip2
format inlucene/benchmark
.Alternatively, benchmark could use the gzip support built into the JDK, and for bzip2 files, it could just support running
bzip2 -dc
command and reading from its stdout? It would avoid the entire mess.