Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable UI Tab for Spark 4.0 and above #6390

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented May 20, 2024

🔍 Description

Spark 4.0 migrated from javax.servlet to jakarta.servlet in SPARK-47118, which breaks the Kyuubi UI tab.

Describe Your Solution 🔧

Temporarily disable UI Tab for Spark 4.0 and above.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Build Kyuubi with Spark 3.5 and successfully launch the Spark engine with Spark 4.0.0 preview1.

image

Checklist 📝

Be nice. Be informative.

@yikf
Copy link
Contributor

yikf commented May 20, 2024

Hi pan, Why does this break the kyuubi ui and is it a known issue with the preview version?

In general, will the kyuubi spark engine tab continue to not support spark 4.0 and above in the future, or will it only be temporary as we now need to test the preview version and this known issue has not yet been fixed?

@pan3793
Copy link
Member Author

pan3793 commented May 20, 2024

@yikf This is a temporary workaround, eventually, we may need to introduce a shim layer to dynamically bind to Spark UI classes (javax.servlet or jakarta.servlet). Please refer to SPARK-47118 for more context

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 58.51%. Comparing base (02e1aa3) to head (2abad8c).

Files Patch % Lines
...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6390      +/-   ##
============================================
- Coverage     58.55%   58.51%   -0.04%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39974    39976       +2     
  Branches       5489     5490       +1     
============================================
- Hits          23406    23393      -13     
- Misses        14070    14079       +9     
- Partials       2498     2504       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 self-assigned this May 20, 2024
@pan3793 pan3793 added this to the v1.9.1 milestone May 20, 2024
@pan3793 pan3793 closed this in 70eadc1 May 20, 2024
pan3793 added a commit that referenced this pull request May 20, 2024
# 🔍 Description

Spark 4.0 migrated from `javax.servlet` to `jakarta.servlet` in SPARK-47118, which breaks the Kyuubi UI tab.

## Describe Your Solution 🔧

Temporarily disable UI Tab for Spark 4.0 and above.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Build Kyuubi with Spark 3.5 and successfully launch the Spark engine with Spark 4.0.0 preview1.

<img width="1339" alt="image" src="https://github.com/apache/kyuubi/assets/26535726/34a001e5-5c70-4928-bf28-743825c0ead3">

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6390 from pan3793/ui-4.0.

Closes #6390

2abad8c [Cheng Pan] Temporarily disable UI Tab for Spark 4.0 and above

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 70eadc1)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member Author

pan3793 commented May 20, 2024

Thanks, merged to master/1.9

@pan3793 pan3793 deleted the ui-4.0 branch May 20, 2024 09:28
pan3793 added a commit that referenced this pull request May 21, 2024
pan3793 added a commit that referenced this pull request May 21, 2024
@pan3793
Copy link
Member Author

pan3793 commented May 21, 2024

Reverted because I have addressed the compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants