IGNITE-22215 Fix for ThinClientIndexQueryTest#testPageSize #11349
Conversation
| .collect(Collectors.toList())); | ||
| } | ||
|
|
||
| assert pageSize >= CNT || !reqs.isEmpty(); |
There was a problem hiding this comment.
pageSize is the param of the test, why do you check it?
There was a problem hiding this comment.
This is a shorter version of
if (pageSize < CNT)
assert !reqs.isEmpty();
where we need to make sure that if the page size is less than the number of entries, then the collection of messages must not be empty.
| reqs.addAll(TestRecordingCommunicationSpi.spi(grid(i)).recordedMessages(true) | ||
| .stream() | ||
| .map(o -> (GridCacheQueryRequest)o) | ||
| .filter(o -> o.type() == null) |
There was a problem hiding this comment.
This filter doesn't affect test results
There was a problem hiding this comment.
The processing of messages has been changed altogether as another check for GridCacheQueryResponse messages has been added.
| for (int i = 0; i < NODES; i++) | ||
| msgs.addAll(TestRecordingCommunicationSpi.spi(grid(i)).recordedMessages(true)); | ||
|
|
||
| assert pageSize >= (CNT - NULLS_CNT) || !msgs.isEmpty(); |
There was a problem hiding this comment.
why do you check pageSize? You set values for the pageSize in 228L
There was a problem hiding this comment.
Check removed. It was a shorter version for
if (pageSize < CNT)
assert !reqs.isEmpty();
But since we decided not to filter out query initiation requests, the 'reqs' collection will never be empty.
|
|
||
| assert reqs.size() == resp.size(); | ||
|
|
||
| for (int i = 0; i < reqs.size(); i++) { |
There was a problem hiding this comment.
let's check that reqs size is expected.
There was a problem hiding this comment.
Check for the expected size of the 'reqs' collection added.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.