feat: Add equality delete writer #372
Open
+591
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
May 21, 2024
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs
Outdated
Show resolved
Hide resolved
sdd
reviewed
May 22, 2024
| impl<B: FileWriterBuilder> IcebergWriter for EqualityDeleteFileWriter<B> { | ||
| async fn write(&mut self, batch: RecordBatch) -> Result<()> { | ||
| let batch = self.project_record_batch_columns(batch)?; | ||
| self.inner_writer.as_mut().unwrap().write(&batch).await |
There was a problem hiding this comment.
We should use ? rather than unwrap() here.
There was a problem hiding this comment.
? is for Result but self.inner_writer is an Option. I think it is reasonable to leave it just Option. Maybe self.inner_writer.as_mut().ok_or_else(...).write(&batch).await is better?
sdd
reviewed
May 22, 2024
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs
Outdated
Show resolved
Hide resolved
sdd
reviewed
May 22, 2024
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs
Outdated
Show resolved
Hide resolved
sdd
reviewed
May 22, 2024
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs
Outdated
Show resolved
Hide resolved
Dysprosium0626
force-pushed
the
add_equality_delete_writer
branch
from
ec21a8e
to
cc1ef1f
Compare
Dysprosium0626
force-pushed
the
add_equality_delete_writer
branch
from
2aa2e5f
to
f4c6cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #341
EqualityDeleteWriterrefers tohttps://iceberg.apache.org/spec/#equality-delete-filesThis pr complete the implementation of
EqualityDeleteWriterand its test case