[HUDI-7723] DayBasedCompactionStrategy supports io bounded #11169
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
May 8, 2024
| @@ -60,6 +62,17 @@ public Comparator<String> getComparator() { | |||
| return comparator; | |||
| } | |||
|
|
|||
| @Override | |||
| public List<HoodieCompactionOperation> orderAndFilter(HoodieWriteConfig writeConfig, | |||
There was a problem hiding this comment.
should we extend from BoundedIOCompactionStrategy and by default does not limit the IO boundary(make it a maximum default value maybe)?
There was a problem hiding this comment.
Maybe add a boolean value is more reasonable. BoundedIOCompactionStrategy has a default config hoodie.compaction.target.io with value 512G. Following your idea，we should add a similar new config like hoodie.compaction.target.io which make it maximum default value. That seems a little conflict.
There was a problem hiding this comment.
512G itself is a value big enough for most of the production use cases, we can use it IMO.
There was a problem hiding this comment.
It's ok if 512G is regarded as the maximum value. I fix it.
github-actions
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This pr is meant to:
Impact
no
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist