mod_ext_filter: fix checks for apr_procattr_limit_set #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existence of the apr_procattr_limit_set function declaration is dependant on the APR_HAVE_STRUCT_RLIMIT define within the APR library. However the user of this function in httpd is inferring the knowledge about its declaration based on the defines: RLIMIT_CPU, RLIMIT_DATA, RLIMIT_VMEM, RLIMIT_AS, RLIMIT_NPROC. This can result in an implicit declaration of function error during a build. Lets fix this by repeating the work done within the mod_cgi module [1]. Add extra conditionals that check for APR_HAVE_STRUCT_RLIMIT define being set. [1] https://svn.apache.org/viewvc?view=revision&revision=1172019 Signed-off-by: Pawel Zalewski <[email protected]>
|
Closing as there is not interest in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existence of the apr_procattr_limit_set function declaration is dependant on the APR_HAVE_STRUCT_RLIMIT define within the APR library.
However the user of this function in httpd is inferring the knowledge about its declaration based on the defines: RLIMIT_CPU, RLIMIT_DATA, RLIMIT_VMEM, RLIMIT_AS, RLIMIT_NPROC. This can result in an implicit declaration of function error during a build.
Lets fix this by repeating the work done within the mod_cgi module [1]. Add extra conditionals that check for APR_HAVE_STRUCT_RLIMIT define being set.
[1] https://svn.apache.org/viewvc?view=revision&revision=1172019