[WIP] Calcite upgrade 1.33 #5196
Draft
+7,454
−5,854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
… BETWEEN, and handle Sargs with nullAs TRUE or FALSE
…edicates are not pushed down to TableScan
…OKUP_OPTIMIZER_MIN
We cannot create a RexNode with BETWEEN anymore. We have to use makeBetween method for it. Also, there's no provision to create a NOT BETWEEN, so had to add a method for it in TestFilterSelectivityEstimator.java Also removed the test testComputeRangePredicateSelectivityBetweenLeftLowerThanRight as we cannot create a BETWEEN where left is higher than right (although the name of the test suggests otherwise). BETWEEN with left lower than right is tested with testComputeRangePredicateSelectivityBetween
RexSimplify can sometimes wrap a RexCall in a CAST, which is unnecesary. One example of this is lateral_view_outer.q, which failed because of this. Tested with: mvn test -pl itests/qtest -Pitests -Dtest=TestMiniLlapLocalCliDriver -Dtest.output.overwrite=true -Dqfile="lateral_view_outer.q"
The plans change because RexBuilder#toComparable doesn't support CASTs, which means that we cannot create a SEARCH operator and thus INs are getting converted to ORs of EQUALS
This was failing because during logical planning key*1 is getting reduced to key in 1.33, whereas it was not reduced in 1.25. Changing it to key*2 will stop the reduction.
soumyakanti3578
force-pushed
the
calcite-upgrade-1.33
branch
from
be47ab1
to
ebe23df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?