-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17526. getMetadataInputStream should use getShareDeleteFileInputStream for windows #6826
Open
dannytbecker
wants to merge
1
commit into
apache:trunk
Choose a base branch
from
dannytbecker:dabecker/HDFS-17526
base: trunk
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hareDeleteFileInputStream for windows #What Use getShareDeleteFileInputStream for windows MetaDataInputStream [HDFS-17526](https://issues.apache.org/jira/browse/HDFS-17526) #Why In our 2.9 branch, we backported [HDFS-10636](https://issues.apache.org/jira/browse/HDFS-10636) but we modified the getMetaDataInputStream() compared to open source. Since this change was never checked in to open-source, branch-3.3-mt does not have this fix for windows. DN Logs: ``` 2024-05-07T19:45:48,429 ERROR [DataXceiver for client DFSClient_iusvr_MWHEEEAP003F671_container_e1349_1715033229940_2291_01_000090_446347524_1 at /2603:10b0:d13:2a:0:0:0:8763:13239 [Receiving block BP-1897851578-10.59.214.126-1624147212071:blk_16605581415_16555930755]] org.apache.hadoop.hdfs.server.datanode.DataNode: MWHEEEAP0028C5A.machines.MWHE01.ap.gbl:10010:DataXceiver error processing WRITE_BLOCK operation remote: /2603:10b0:d13:2a:0:0:0:8763:13239 local: /2603:10b0:d13:10:0:0:0:1543:10010 java.io.IOException: Block FinalizedReplica, blk_16605581415_16555930755, FINALIZED getNumBytes() = 521615760 getBytesOnDisk() = 521615760 getVisibleLength()= 521615760 getVolume() = G:\data\hdfs\data getBlockURI() = file:/G:/data/hdfs/data/current/BP-1897851578-10.59.214.126-1624147212071/current/finalized/subdir5/subdir16/blk_16605581415 reopen failed. Unable to move meta file G:\data\hdfs\data\current\BP-1897851578-10.59.214.126-1624147212071\current\finalized\subdir5\subdir16\blk_16605581415_16555930755.meta to G:\data\hdfs\data\current\BP-1897851578-10.59.214.126-1624147212071\current\finalized\subdir5\subdir16\blk_16605581415_16557042956.meta at org.apache.hadoop.hdfs.server.datanode.LocalReplica.bumpReplicaGS(LocalReplica.java:385) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.recoverClose(FsDatasetImpl.java:1423) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at org.apache.hadoop.hdfs.server.datanode.DataXceiver.writeBlock(DataXceiver.java:778) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opWriteBlock(Receiver.java:176) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:110) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:294) ~[hadoop-hdfs-3.3.4-MT-SNAPSHOT.jar:?] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202] Caused by: java.io.IOException: Failed to rename G:\data\hdfs\data\current\BP-1897851578-10.59.214.126-1624147212071\current\finalized\subdir5\subdir16\blk_16605581415_16555930755.meta to G:\data\hdfs\data\current\BP-1897851578-10.59.214.126-1624147212071\current\finalized\subdir5\subdir16\blk_16605581415_16557042956.meta due to failure in native rename. 32: The process cannot access the file because it is being used by another process. at org.apache.hadoop.hdfs.server.common.Storage.rename(Storage.java:1290) ~[hadoop-...
goiri
approved these changes
May 14, 2024
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In HDFS-10636, the getDataInputStream method uses the getShareDeleteFileInputStream for windows, but the getMetaDataInputStream does not use this. The following error can happen when a DataNode is trying to update the genstamp on a block in Windows.
DataNode Logs:
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?