Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][jdbc][docs] Remove dead link #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[hotfix][jdbc][docs] Remove dead link #88

wants to merge 2 commits into from
+5 −2

Conversation

GOODBOY008
Copy link
Member

@GOODBOY008 GOODBOY008 commented Jan 4, 2024 •
edited
Loading

Changes:

  1. Remove dead links in document.

@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Jan 4, 2024 •
edited
Loading

@MartijnVisser @eskabetxe Please take a look, Thank you~

MartijnVisser
MartijnVisser requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 Like I've said in the Jira, this shouldn't be addressed per connector but generically for the shared_utils.

Next to that, I'm not sure this solves the problem. You're only checking for dead links in the existing connector docs, but it doesn't actually check the integration of the docs when the Flink documentation is being built. That's where the error occurred.

@GOODBOY008 GOODBOY008 changed the title [FLINK-33970] Add necessary checks for connector document [FLINK-33970][jdbc][docs] Remove dead link Jan 5, 2024
@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Jan 5, 2024 •
edited
Loading

@MartijnVisser I want to fix dead link in document first. And I also want to add dead link check into https://github.com/apache/flink-connector-shared-utils/tree/ci_utils and pr is apache/flink-connector-shared-utils#33 ,because hugo build cannot check dead link in document. And also in flink repo should add this check too?

eskabetxe
eskabetxe approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@eskabetxe eskabetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008
Copy link
Member Author

@MartijnVisser PTAL , Thank you~

@GOODBOY008 GOODBOY008 changed the title [FLINK-33970][jdbc][docs] Remove dead link [hotfix][jdbc][docs] Remove dead link Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskabetxe eskabetxe eskabetxe approved these changes

@MartijnVisser MartijnVisser Awaiting requested review from MartijnVisser

Assignees
No one assigned
Labels
component=BuildSystem component=Documentation
Projects
None yet
Milestone
No milestone
3 participants
@GOODBOY008 @MartijnVisser @eskabetxe