Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-740]Fix eagle-query checkstyle warnings #647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koone
Copy link
Contributor

@koone koone commented Nov 11, 2016

[EAGLE-740]Fix eagle-query checkstyle warnings

http://issues.apache.org/jira/browse/EAGLE-740

@haoch
Copy link
Member

haoch commented Nov 14, 2016

Classes under org.apache.eagle.query.antlr.generated is automatically generated by antlr, so suggest to exclude it from checkstyle and keep the original code.

@koone
Copy link
Contributor Author

koone commented Nov 14, 2016

revert eagle-antlr and exclude Classes under org.apache.eagle.query.antlr.generated from checstyle
@haoch could you please check again

@haoch
Copy link
Member

haoch commented Nov 14, 2016

Could you please rollback the code format of files under org.apache.eagle.query.antlr.generated too?

@koone
Copy link
Contributor Author

koone commented Nov 15, 2016

@haoch the last commit is already roolback the code format

@haoch
Copy link
Member

haoch commented Nov 15, 2016

@koone thanks

@haoch
Copy link
Member

haoch commented Nov 15, 2016

@koone As the PR changed too many files, please it may take a few days for reviewing.

@jhsenjaliya
Copy link
Contributor

@haoch , do you need any help on reviewing this?
@koone, Can you please rebase this PR ? Thanks

@jhsenjaliya
Copy link
Contributor

Hi @koone, This would be good to add in 0.5 branch, would you have time to rebase this and address comments from @haoch ? Thanks

@jhsenjaliya
Copy link
Contributor

I spent lot of time in rebasing this, but eventually it got very confusing since there are lot of files ( ~1500) to be rebased, which i did (jhsenjaliya:EAGLE-740-rebased) but there are multiple layers of rebase needs to be done, and i afraid i cant pick the right candidate wherever there are conflicts. so I am leaving this aside for 0.5 release, and we can get to this afterwards. this is important and we should take this change eventually. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants