Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to reveal reason to persist the hydrants #16409

Merged

Conversation

kaisun2000
Copy link
Contributor

@kaisun2000 kaisun2000 commented May 7, 2024

Fixes #16408 16408

Description

Add a line of logging to give a signal as why persist is going to be triggered next in the peon. This would be useful to tune the ingestion spec.

The possible reasons are:

  • maxRowInMemory reached
  • maxBytesInMemory reached
  • nextFlush time reached

Currently only "IncreamentalPersist" code path has this logging. Here we added the logging for the rest code path when increamental persist is not enabled.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@Pankaj260100
Copy link
Contributor

The possible reasons are:
maxRowInMemory reached
maxBytesInMemory reached
nextFlush time reached

It also persist all the data to disk when the ingestion worker wants to publish the data to deep storage.

@kfaraz kfaraz merged commit 91cd07d into apache:master May 15, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream ingestion persist reason to be revealed
3 participants