fix capacity issue for category aware #16391
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15847.
Description
Fix the bug of capacity api which is not category aware
The proposal solution is following:
Summary: according to the WorkerSelectStrategy(category based or not), set the category capacity in TotalWorkerCapacityResponse, in client side, compare the category capacity and totalWorkerCapacity * taskSlotRatio, take the smaller one
Fixed the bug 15847
Release note
Fix the bug of getCompactionTaskCapacity which is not category aware
Update the getTotalWorkerCapacity of OverlordResource
if WorkerSelectStrategy is category based strategy(FillCapacityWithCategorySpecWorkerSelectStrategy and EqualDistributionWithCategorySpecWorkerSelectStrategy), TotalWorkerCapacityResponse will contains the capacity group by category.
Key changed/added classes in this PR
CategoryCapacityInfo
OverlordResource
TotalWorkerCapacityResponse
EqualDistributionWithCategorySpecWorkerSelectStrategy
FillCapacityWithCategorySpecWorkerSelectStrategy
WorkerSelectStrategy
WorkerSelectUtils
OverlordResourceTest
EqualDistributionWithCategorySpecWorkerSelectStrategyTest
FillCapacityWithCategorySpecWorkerSelectStrategyTest
IndexingCategoryCapacityInfo
IndexingTotalWorkerCapacityInfo
IndexingWorker
CompactSegments
CoordinatorDutyUtils
KillUnusedSegments
OverlordClientImplTest
CompactSegmentsTest
KillUnusedSegmentsTest
This PR has: