[feature](datatype) add BE config to allow zero date #34961
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return from_date_str_base(date_str, len, scale, &local_time_zone); | ||
| const cctz::time_zone& local_time_zone, int scale /* = -1*/, | ||
| bool convert_zero) { | ||
| return from_date_str_base(date_str, len, scale, &local_time_zone, convert_zero); | ||
| } | ||
| template <typename T> | ||
| bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int scale, |
There was a problem hiding this comment.
warning: function 'from_date_str_base' has cognitive complexity of 118 (threshold 50) [readability-function-cognitive-complexity]
bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int scale,
^Additional context
be/src/vec/runtime/vdatetime_value.cpp:2000: +1, including nesting penalty of 0, nesting level increased to 1
while (ptr < end && isspace(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2000: +1
while (ptr < end && isspace(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2003: +1, including nesting penalty of 0, nesting level increased to 1
if (ptr == end || !isdigit(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2003: +1
if (ptr == end || !isdigit(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2008: +1, including nesting penalty of 0, nesting level increased to 1
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^be/src/vec/runtime/vdatetime_value.cpp:2008: +1
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^be/src/vec/runtime/vdatetime_value.cpp:2008: +1
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^be/src/vec/runtime/vdatetime_value.cpp:2018: +1, including nesting penalty of 0, nesting level increased to 1
if (pos == end || *pos == '.' ||
^be/src/vec/runtime/vdatetime_value.cpp:2018: +1
if (pos == end || *pos == '.' ||
^be/src/vec/runtime/vdatetime_value.cpp:2020: +2, including nesting penalty of 1, nesting level increased to 2
if (digits == 4 || digits == 8 || digits >= 14) {
^be/src/vec/runtime/vdatetime_value.cpp:2020: +1
if (digits == 4 || digits == 8 || digits >= 14) {
^be/src/vec/runtime/vdatetime_value.cpp:2022: +1, nesting level increased to 2
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2032: +1, including nesting penalty of 0, nesting level increased to 1
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^be/src/vec/runtime/vdatetime_value.cpp:2032: +1
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^be/src/vec/runtime/vdatetime_value.cpp:2035: +1
bool scan_to_delim = (!is_interval_format) && (field_idx != 6);
^be/src/vec/runtime/vdatetime_value.cpp:2036: +2, including nesting penalty of 1, nesting level increased to 2
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--)) { // field_len <= 7
^be/src/vec/runtime/vdatetime_value.cpp:2036: +1
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--)) { // field_len <= 7
^be/src/vec/runtime/vdatetime_value.cpp:2036: +1
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--)) { // field_len <= 7
^be/src/vec/runtime/vdatetime_value.cpp:2041: +2, including nesting penalty of 1, nesting level increased to 2
if (field_idx == 6) {
^be/src/vec/runtime/vdatetime_value.cpp:2042: +3, including nesting penalty of 2, nesting level increased to 3
if constexpr (is_datetime) {
^be/src/vec/runtime/vdatetime_value.cpp:2047: +4, including nesting penalty of 3, nesting level increased to 4
if (scale >= 0) {
^be/src/vec/runtime/vdatetime_value.cpp:2058: +5, including nesting penalty of 4, nesting level increased to 5
if (reminder >= 5 * normalizer) {
^be/src/vec/runtime/vdatetime_value.cpp:2063: +5, including nesting penalty of 4, nesting level increased to 5
if (temp_val == int_exp10(7)) {
^be/src/vec/runtime/vdatetime_value.cpp:2066: +1, nesting level increased to 5
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2072: +4, including nesting penalty of 3, nesting level increased to 4
while (ptr < end && isdigit(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2072: +1
while (ptr < end && isdigit(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2075: +1, nesting level increased to 3
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2083: +2, including nesting penalty of 1, nesting level increased to 2
if (temp_val > 999999L) {
^be/src/vec/runtime/vdatetime_value.cpp:2089: +2, including nesting penalty of 1, nesting level increased to 2
if (field_idx == 6) {
^be/src/vec/runtime/vdatetime_value.cpp:2093: +1, nesting level increased to 2
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2099: +2, including nesting penalty of 1, nesting level increased to 2
if (ptr == end) {
^be/src/vec/runtime/vdatetime_value.cpp:2105: +2, including nesting penalty of 1, nesting level increased to 2
if (UNLIKELY((field_idx > 2 ||
^be/src/vec/runtime/vdatetime_value.cpp:2107: +1
&& time_zone_begins(ptr, end))) {
^be/src/vec/runtime/vdatetime_value.cpp:2105: +1
if (UNLIKELY((field_idx > 2 ||
^be/src/vec/runtime/vdatetime_value.cpp:2108: +3, including nesting penalty of 2, nesting level increased to 3
if (local_time_zone == nullptr) {
^be/src/vec/runtime/vdatetime_value.cpp:2111: nesting level increased to 3
auto get_tz_offset = [&](const std::string& str_tz,
^be/src/vec/runtime/vdatetime_value.cpp:2114: +4, including nesting penalty of 3, nesting level increased to 4
if (!TimezoneUtils::find_cctz_time_zone(str_tz, given_tz)) {
^be/src/vec/runtime/vdatetime_value.cpp:2125: +3, including nesting penalty of 2, nesting level increased to 3
} catch ([[maybe_unused]] Exception& e) {
^be/src/vec/runtime/vdatetime_value.cpp:2132: +2, including nesting penalty of 1, nesting level increased to 2
if (field_idx == 2 && *ptr == 'T') {
^be/src/vec/runtime/vdatetime_value.cpp:2132: +1
if (field_idx == 2 && *ptr == 'T') {
^be/src/vec/runtime/vdatetime_value.cpp:2140: +2, including nesting penalty of 1, nesting level increased to 2
if (field_idx == 5) {
^be/src/vec/runtime/vdatetime_value.cpp:2141: +3, including nesting penalty of 2, nesting level increased to 3
if (*ptr == '.') {
^be/src/vec/runtime/vdatetime_value.cpp:2146: +4, including nesting penalty of 3, nesting level increased to 4
if constexpr (is_datetime) {
^be/src/vec/runtime/vdatetime_value.cpp:2148: +1, nesting level increased to 4
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2151: +1, nesting level increased to 3
} else if (isdigit(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2159: +2, including nesting penalty of 1, nesting level increased to 2
while (ptr < end && (ispunct(*ptr) || isspace(*ptr))) {
^be/src/vec/runtime/vdatetime_value.cpp:2159: +1
while (ptr < end && (ispunct(*ptr) || isspace(*ptr))) {
^be/src/vec/runtime/vdatetime_value.cpp:2159: +1
while (ptr < end && (ispunct(*ptr) || isspace(*ptr))) {
^be/src/vec/runtime/vdatetime_value.cpp:2160: +3, including nesting penalty of 2, nesting level increased to 3
if (isspace(*ptr)) {
^be/src/vec/runtime/vdatetime_value.cpp:2161: +4, including nesting penalty of 3, nesting level increased to 4
if (((1 << field_idx) & allow_space_mask) == 0) {
^be/src/vec/runtime/vdatetime_value.cpp:2165: +3, including nesting penalty of 2, nesting level increased to 3
if (*ptr == '-') {
^be/src/vec/runtime/vdatetime_value.cpp:2174: +1, including nesting penalty of 0, nesting level increased to 1
if (!is_interval_format) {
^be/src/vec/runtime/vdatetime_value.cpp:2177: +1, including nesting penalty of 0, nesting level increased to 1
for (; field_idx < MAX_DATE_PARTS; ++field_idx) {
^be/src/vec/runtime/vdatetime_value.cpp:2181: +1, including nesting penalty of 0, nesting level increased to 1
if (year_len == 2) {
^be/src/vec/runtime/vdatetime_value.cpp:2182: +2, including nesting penalty of 1, nesting level increased to 2
if (date_val[0] < YY_PART_YEAR) {
^be/src/vec/runtime/vdatetime_value.cpp:2184: +1, nesting level increased to 2
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2189: +1, including nesting penalty of 0, nesting level increased to 1
if (num_field < 3) {
^be/src/vec/runtime/vdatetime_value.cpp:2192: +1, including nesting penalty of 0, nesting level increased to 1
if (is_invalid(date_val[0], date_val[1], date_val[2], 0, 0, 0, 0)) {
^be/src/vec/runtime/vdatetime_value.cpp:2193: +2, including nesting penalty of 1, nesting level increased to 2
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 && convert_zero) {
^be/src/vec/runtime/vdatetime_value.cpp:2193: +1
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 && convert_zero) {
^be/src/vec/runtime/vdatetime_value.cpp:2196: +1, nesting level increased to 2
} else {
^be/src/vec/runtime/vdatetime_value.cpp:2205: +1, including nesting penalty of 0, nesting level increased to 1
if constexpr (!is_datetime) {
^be/src/vec/runtime/vdatetime_value.cpp:2206: +2, including nesting penalty of 1, nesting level increased to 2
if (sec_offset) {
^be/src/vec/runtime/vdatetime_value.cpp:2208: +3, including nesting penalty of 2, nesting level increased to 3
if (!tmp.check_range_and_set_time(date_val[0], date_val[1], date_val[2], date_val[3],
^be/src/vec/runtime/vdatetime_value.cpp:2212: +3, including nesting penalty of 2, nesting level increased to 3
if (!tmp.date_add_interval<TimeUnit::SECOND>(
^be/src/vec/runtime/vdatetime_value.cpp:2221: +1, including nesting penalty of 0, nesting level increased to 1
if (!check_range_and_set_time(date_val[0], date_val[1], date_val[2], date_val[3], date_val[4],
^be/src/vec/runtime/vdatetime_value.cpp:2226: +1, including nesting penalty of 0, nesting level increased to 1
return sec_offset ? date_add_interval<TimeUnit::SECOND>(
^
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
run buildall |
|
TeamCity be ut coverage result: |
|
Please add a regression test. |
|
run buildall |
|
TeamCity be ut coverage result: |
dataroaring
force-pushed
the
datetime-zero
branch
from
73b6411
to
ff5a83e
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
Co-authored-by: Gabriel <[email protected]>
Co-authored-by: Gabriel <[email protected]>
Co-authored-by: Gabriel <[email protected]>
Proposed changes
Add a BE config
allow_zero_date, which defaults tofalse.If set to
false,0000-00-00will be converted toNULL(old behavior).If set to
true,0000-00-00will be converted to0000-01-01.Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...
Co-authored-by: Gabriel [email protected]