Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create initial release process scripts for official ASF source release #429

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 14, 2024

Which issue does this PR close?

Part of #394

Rationale for this change

We need to establish the basic ASF release process

What changes are included in this PR?

  • Copy create-tarball, release-tarball, verify-release-candidate scripts from DataFusion and modify them for Comet
  • Change the crate name from comet to datafusion-comet (comet was taken, and I have reserved datafusion-comet in crates.io)
  • Add placeholder README

How are these changes tested?

They are not tested yet. I will test them prior to our first release.

@@ -16,7 +16,7 @@
# under the License.

[package]
name = "comet"
name = "datafusion-comet"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a comet crate, so I renamed this. I have reserved the crate: https://crates.io/crates/datafusion-comet

@andygrove andygrove marked this pull request as ready for review May 14, 2024 16:14
@andygrove andygrove requested review from sunchao and viirya May 14, 2024 16:14
@andygrove
Copy link
Member Author

@snmvaughan @parthchandra please review when you have the time

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this is for publishing cargo package. But I think Comet should be released as a maven package at maven repository? So users can simply add Comet as a dependency in their pom file?

@andygrove
Copy link
Member Author

Hmm, I think this is for publishing cargo package. But I think Comet should be released as a maven package at maven repository? So users can simply add Comet as a dependency in their pom file?

It depends whether we want to allow other Rust projects to be able to use the Spark-compatible expressions that we are implementing, outside of the Comet/Spark integration.

The maven release will be needed for sure.

@andygrove andygrove changed the title chore: Create initial release process scripts chore: Create initial release process scripts for official ASF source release May 14, 2024
core/Cargo.toml Outdated Show resolved Hide resolved
@andygrove
Copy link
Member Author

Hmm, I think this is for publishing cargo package. But I think Comet should be released as a maven package at maven repository? So users can simply add Comet as a dependency in their pom file?

Also, regardless of whether we choose to publish the crate or not, I think it is better to not use the name of an existing crate, and good to have the author information be consistent with other DataFusion crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants