Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade commons-io from 2.15.1 to 2.16.1 #513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madrob
Copy link

@madrob madrob commented Apr 6, 2024

Currently uses the snapshot version, can update to full release when that is available.

Also closes #505

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 93.58974% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.73%. Comparing base (1887b3d) to head (caf4158).
Report is 225 commits behind head on master.

Files Patch % Lines
.../commons/compress/archivers/sevenz/SevenZFile.java 92.50% 0 Missing and 3 partials ⚠️
...ommons/compress/archivers/zip/ZipArchiveEntry.java 0.00% 0 Missing and 1 partial ⚠️
...a/org/apache/commons/compress/utils/TimeUtils.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
- Coverage     80.76%   80.73%   -0.04%     
- Complexity     6801     6828      +27     
============================================
  Files           348      348              
  Lines         24945    25051     +106     
  Branches       4029     4035       +6     
============================================
+ Hits          20148    20224      +76     
- Misses         3269     3296      +27     
- Partials       1528     1531       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garydgregory
Copy link
Member

@madrob
Thank you for the PR.
Please run mvn by itself to run the default Maven goal and catch all build errors.

@garydgregory
Copy link
Member

@madrob
I think we need to address https://issues.apache.org/jira/browse/COMPRESS-675 before this PR. Any thoughts?

@madrob madrob marked this pull request as ready for review April 23, 2024 19:27
@garydgregory
Copy link
Member

@madrob
I had to fix a couple of bugs, please rebase on git master.
TY!

@garydgregory
Copy link
Member

@madrob I had to fix a couple of bugs, please rebase on git master. TY!

https://issues.apache.org/jira/browse/COMPRESS-675 has been addressed.

@garydgregory
Copy link
Member

@madrob
Would you please rebase on git master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants