Change source encoding to UTF-8 #389
Conversation
|
Hello @mkoncek |
| @@ -297,7 +297,7 @@ private void addPaxHeadersForBigNumbers(final Map<String, String> paxHeaders, | |||
| TarConstants.MAXID); | |||
| // libarchive extensions | |||
| addFileTimePaxHeader(paxHeaders, "LIBARCHIVE.creationtime", entry.getCreationTime()); | |||
| // star extensions by J�rg Schilling | |||
| // star extensions by Jörg Schilling | |||
There was a problem hiding this comment.
Could also use:
// star extensions by Joerg Schilling
There was a problem hiding this comment.
Actually, strictly (legally) speaking, "Jörg" and "Joerg" are not the same name, just like "Möller" and "Moeller" are not. So better stick to the original for credits / Copyrights, if possible.
|
maven-compiler-plugin is declared in
@sebbASF That would work too, but I believe it is time we can afford such luxury as using non-ASCII-only characters in sources. |
|
I can confirm that changing the encoding causes the compile to report an ERROR, but the build succeeds: $ mvn clean compile -Dcommons.encoding=UTF8 I've tried experimenting with -Dmaven.compiler.failOnWarning=true (and failOnError), but Maven does not fail the build. However, adding -Dcommons.compiler.fork=true does cause the build to fail. |
|
Unfortunately, when using fork=true, some informational messages are not shown, see: |
Maybe by adding a UTF-8 encoded test asset, plus a test that reads the file in binary mode and compares to the expected bytes? |
We have a project which bootstraps Maven. It manually calls
javacand we encountered a problem with source encoding.I would like to unify source encodings to UTF-8.