[CALCITE-6358] Support all PostgreSQL 14 date/time patterns for to_char #3792
Conversation
normanj-bitquill
commented
May 15, 2024
normanj-bitquill
commented
- Splits the PostgreSQL toChar function off to its own function
- Does not implement SP suffix
- Timezone patterns are supported but all datetimes are in local timezone
* Splits the PostgreSQL toChar function off to its own function * Does not implement SP suffix * Timezone patterns are supported but all datetimes are in local timezone
normanj-bitquill
changed the title
|
This PR is the same as Needed to recreate to fix CI issues. |
|
| 13 | ||
| !ok | ||
|
|
||
| select to_char(timestamp '2022-06-03 13:15:48.678', 'MI'); |
| * converts {@code timestamp} to string according to the given {@code format}. */ | ||
| @LibraryOperator(libraries = {POSTGRESQL}) | ||
| public static final SqlFunction TO_CHAR_PG = | ||
| new SqlBasicFunction("TO_CHAR", SqlKind.OTHER_FUNCTION, |
There was a problem hiding this comment.
Can this be used directly?
SqlBasicFunction.create("TO_CHAR",
ReturnTypes.VARCHAR_NULLABLE,
OperandTypes.TIMESTAMP_STRING,
SqlFunctionCategory.TIMEDATE);
There was a problem hiding this comment.
@YiwenWu Unfortunately not. The implementations of hashCode and equals are from SqlOperator and only looks at the name and kind.
There is also a TO_CHAR for MySQL/Oracle and this new one for PostgreSQL. Since they have the same name and kind they would conflict in a HashMap. Using a new class here gets around the collision. Another solution is to add equals and hashCode implementations to SqlBasicFunction.
There was a problem hiding this comment.
@normanj-bitquill Understood.
A small suggestion, I think the SqlBasicFunction constructor is designed to be as private as possible. Is it possible to add a method to create the corresponding anonymous class, for example:
public static SqlBasicFunction overloadCreate(String name,
SqlReturnTypeInference returnTypeInference,
SqlOperandTypeChecker operandTypeChecker, SqlFunctionCategory category) {
return new SqlBasicFunction(name, SqlKind.OTHER_FUNCTION,
SqlSyntax.FUNCTION, true, returnTypeInference, null,
OperandHandlers.DEFAULT, operandTypeChecker, 0,
category, call -> SqlMonotonicity.NOT_MONOTONIC, false){};
}
|
This looks good, we can probably merge this one and close #3773 |
