Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) #3785

Merged
merged 1 commit into from
Jun 1, 2024
Merged

[CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) #3785

merged 1 commit into from
Jun 1, 2024

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented May 3, 2024 •
edited

@caicancai caicancai requested a review from mihaibudiu May 6, 2024 00:34
@caicancai caicancai requested a review from mihaibudiu May 7, 2024 14:48
@caicancai caicancai requested a review from mihaibudiu May 10, 2024 16:09
julianhyde
julianhyde reviewed May 10, 2024
View reviewed changes
site/_docs/reference.md Outdated Show resolved Hide resolved
@caicancai caicancai force-pushed the nvl2 branch 2 times, most recently from 325b5d8 to 0fd01ab Compare May 12, 2024 08:55
@caicancai caicancai changed the title [CALCITE-6397] Add NVL2 function (enabled in Spark library) [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) May 12, 2024
@caicancai caicancai requested a review from julianhyde May 14, 2024 01:49
@caicancai
Copy link
Member Author

@YiwenWu If you have time, can you help me take a look at this PR? Thank you

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@caicancai caicancai requested a review from YiwenWu May 29, 2024 16:02
YiwenWu
YiwenWu approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@YiwenWu YiwenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caicancai
Copy link
Member Author

@mihaibudiu @julianhyde @YiwenWu
Thanks for the review, squashed

@mihaibudiu mihaibudiu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label May 31, 2024
@mihaibudiu mihaibudiu merged commit eb92f96 into apache:main Jun 1, 2024
33 of 34 checks passed
@caicancai caicancai deleted the nvl2 branch June 1, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiwenWu YiwenWu YiwenWu approved these changes

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@julianhyde julianhyde Awaiting requested review from julianhyde

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
4 participants
@caicancai @julianhyde @YiwenWu @mihaibudiu