Support proxy and generic call of baidu protocol #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
May 6, 2024
| @@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*); | |||
| // Get/own SampledRequest for sending dumped requests. | |||
| // Deleted along with controller. | |||
| void reset_sampled_request(SampledRequest* req); | |||
| const SampledRequest* sampled_request() { return _sampled_request; } | |||
| const SampledRequest* sampled_request() const { return _sampled_request; } | |||
There was a problem hiding this comment.
感觉这个名字叫sampled_request是不是不太合适了，可以改成baidu_rpc_request或者baidu_std_request
There was a problem hiding this comment.
- 也不太合适，SampledRequest不仅支持baidu-std协议，还支持其他协议。
- 改名字是不是对兼容性不友好？
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2405
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: