Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old rpcz directory even if program crash #2610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yanglimingcn
Copy link
Contributor

What problem does this PR solve?

rpcz目录在正常运行过程会周期性的删除旧的数据,但是如果在程序运行一段时间crash掉或者被kill掉,原来的rpcz目录不会释放掉,日积月累会占用很多空间。
这个PR会在rpcz启动的时候并且rpcz_keep_span_db为false的情况下,清理旧的数据。

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@yanglimingcn yanglimingcn force-pushed the bugfix/remove_old_rpcz_directory branch 2 times, most recently from 14c6f58 to b0ddaef Compare April 22, 2024 12:15
src/brpc/span.cpp Outdated Show resolved Hide resolved
@chenBright
Copy link
Contributor

master分支已经修复了ci的问题,可以更新一下PR。

@yanglimingcn yanglimingcn force-pushed the bugfix/remove_old_rpcz_directory branch from b0ddaef to a00d4fb Compare April 23, 2024 09:45
@yanglimingcn yanglimingcn force-pushed the bugfix/remove_old_rpcz_directory branch from a00d4fb to 4e8a5e6 Compare May 1, 2024 00:50
src/brpc/span.cpp Outdated Show resolved Hide resolved
@yanglimingcn yanglimingcn force-pushed the bugfix/remove_old_rpcz_directory branch from 4e8a5e6 to fc4cf35 Compare May 6, 2024 06:14
@yanglimingcn yanglimingcn force-pushed the bugfix/remove_old_rpcz_directory branch from fc4cf35 to 5864de6 Compare May 6, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants