Better mixed Java/Python error messages for external transforms. #31284
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| without_java_traceback = s + '\n' | ||
| for p in traceback_lines: | ||
| without_java_traceback = re.sub( | ||
| fr'\n{p}$', '', without_java_traceback, flags=re.M) |
There was a problem hiding this comment.
IIUC, this sets every line that matches the pattern within the stack trace to an empty string. Is that correct ?
(probably expand documentation to explain the logic here)
| @@ -750,7 +751,7 @@ def expand(self, pvalueish): | |||
| with ExternalTransform.service(expansion_service) as service: | |||
| response = service.Expand(request) | |||
| if response.error: | |||
| raise RuntimeError(response.error) | |||
| raise RuntimeError(_sanitize_java_traceback(response.error)) | |||
There was a problem hiding this comment.
For transform service, we combine the errors from all expansion service container and return them together. Usually one of them is useful while other is a trivial error (for example, URN not available). Seems like this might result in useful Python errors being deleted in that case ?
There was a problem hiding this comment.
No. We don't actually delete anything, just copy the (hopefully) relevent bits to the bottom of the wall of text.
There was a problem hiding this comment.
Probably let's also add a unit test ?
|
Any more concerns before getting this merged? |
…che#31284) In particular, Java tracebacks read bottom to top, whereas Python tracebacks read top to bottom, resulting in the actual error message being often sandwiched in the middle of two walls of text.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.