feat(k8s-discovery): support mTLS #8699
Conversation
chore: fix kubernetes ci environment variables chore: fix kubernetes ci environment variables
.github/workflows/kubernetes-ci.yml
Outdated
|
|
||
| export BASE64_CSR=$(cat ./t/certs/k8s_mtls.csr | base64 | tr -d '\n') | ||
|
|
||
| envsubst < ./t/certs/k8s_mtls_csr.yaml | kubectl apply -f - |
There was a problem hiding this comment.
It would be better to set up a mtls proxy in the CI. Pros:
- don't need to touch current k8s config
- don't need to add cert config in non-mtls test
- we can cover non-mtls path in the test
- we can test different cert without duplicate k8s env
|
Please make the CI pass, thanks! |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
|
@e1ijah1 do you have time to fix comments and make CI happy? thanks |
I would like to try to fix the CI this weekend😊 |
great 👍 |
|
@e1ijah1 Any progress so far here? |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
@e1ijah1 Are you still working on this PR? |
|
@e1ijah1 Can you resolve the merge conflicts and make some progress on this PR? |
|
@e1ijah1 Looks like you're no longer available. Maybe @shreemaan-abhishek can take this one. |
|
Is there anyone working on this issue? |
Description
support mTLS authentication with kubernetes apiserver for discovery
Fixes #7516
Checklist