fix(k8s): watch_endpoint_slices_schema should be watch_endpoint_slices #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config watch_endpoint_slices not watch_endpoint_slices_schema
monkeyDluffy6017
changed the title
|
Can we add test cases to cover this? |
|
@paradin are you still available to work on this? |
nitishfy
reviewed
Apr 23, 2024
| @@ -431,7 +431,7 @@ local function single_mode_init(conf) | |||
|
|
|||
| local default_weight = conf.default_weight | |||
| local endpoints_informer, err | |||
| if conf.watch_endpoint_slices_schema then | |||
| if conf.watch_endpoint_slices then | |||
There was a problem hiding this comment.
Suggested change
| if conf.watch_endpoint_slices then | |
| if conf.watch_endpoint_slices then |
I don't understand why would you need that? What is the problem it is trying to solve here?
nitishfy
reviewed
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config watch_endpoint_slices not watch_endpoint_slices_schema
Description
Fixes # (issue)
Checklist