Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example AzureContainerInstancesOperator #39466

Merged

Conversation

Kylea650
Copy link
Contributor

@Kylea650 Kylea650 commented May 7, 2024

Small documentation update found during testing of #39156 for release of microsoft.azure 10.1.0rc1 #39346.

#39156/microsoft.azure 10.1.0rc1 has been tested however the example above the code did not work and did not show users how to use the new available api configurations properly.

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladkal
Copy link
Contributor

eladkal commented May 13, 2024

Can you fix static checks?

@Kylea650
Copy link
Contributor Author

Can you fix static checks?

Should be good now.

@josh-fell josh-fell merged commit ecf6e57 into apache:main May 14, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants