feat: anymaniax#352 support allOf

[yokoyama-takuya]

Status

READY

Fix #352

Description

fix allOf type definition
e.g. #352

Related PRs

#503

Change

before

export type GetPets200PetsItemAllOf = {
  /** required name */
  name?: unknown;
  /** @deprecated */
  owner?: unknown;
};

export type GetPets200PetsItem = Pet & unknown & GetPets200PetsItemAllOf;

export type GetPets200 = {
  pets?: GetPets200PetsItem[];
};

/**
 * default Person description
 */
export interface Person {
  id: string;
  /** default Person name */
  name?: string;
}

export type PetOwnerAllOf = {
  /** required name */
  name?: unknown;
};

export type PetOwner = Person & PetOwnerAllOf;

/**
 * default Pet description
 */
export interface Pet {
  id?: string;
  /** default Pet name */
  name?: string;
  owner: PetOwner;
}

after

/**
 * default Person description
 * @deprecated
 */
export type GetPets200PetsItemOwner = {
  id: string;
  /** required name */
  name: string;
};

/**
 * default Pet description
 */
export type GetPets200PetsItem = {
  id?: string;
  /** required name */
  name: string;
  /**
   * default Person description
   * @deprecated
   */
  owner: GetPets200PetsItemOwner;
};

export type GetPets200 = {
  pets?: GetPets200PetsItem[];
};

/**
 * default Person description
 */
export interface Person {
  id: string;
  /** default Person name */
  name?: string;
}

/**
 * default Person description
 */
export type PetOwner = {
  id: string;
  /** required name */
  name: string;
};

/**
 * default Pet description
 */
export interface Pet {
  id?: string;
  /** default Pet name */
  name?: string;
  /** default Person description */
  owner: PetOwner;
}

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

[yokoyama-takuya]

@anymaniax Resubmitted a fix pull request for allOf. I have rewritten it to a simpler code, so please consider it.

[yokoyama-takuya]

@anymaniax Thanks for the review. I replied.

[anymaniax]

I did other test with more complex specification. I got a RangeError: Maximum call stack size exceeded.

[yokoyama-takuya]

@anymaniax Can I have the Swagger file that I tested here?

[anymaniax]

I cannot share it but will try to do a reproduction of the issue

[yokoyama-takuya]

@anymaniax In specs where the elements of objects and arrays are cyclically referenced, as expected. I wonder if the recursive function never ends. Is that API realistic?