Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS theme #3670

Closed
wants to merge 4 commits into from
Closed

Update AWS theme #3670

wants to merge 4 commits into from

Conversation

1chooo
Copy link

@1chooo 1chooo commented Feb 24, 2024

add aws-technical theme

add aws-technical theme
Copy link

vercel bot commented Feb 24, 2024

@1chooo is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the themes Feature, Enhancement, Fixes related to themes. label Feb 24, 2024
Copy link
Contributor

github-actions bot commented Feb 24, 2024

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up 👍 emojis (see #1935). We expect to see at least 10-15 thumbs up before making a decision to merge your pull request into the master branch. Remember that you can also support themes of other contributors that you liked to speed up their merge.

Warning

Please do not submit a pull request with a batch of themes, since it will be hard to judge how the community will react to each of them. We will only merge one theme per pull request. If you have several themes, please submit a separate pull request for each of them. Situations when you have several versions of the same theme (e.g. light and dark) are an exception to this rule.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

  • ✔️ aws_dark

Result: ✔️ All themes are valid.

Details

Aws_dark theme preview

title_color: #e47911 | icon_color: #e47911 | text_color: #f5f5f5 | bg_color: #232f3e

Preview Link

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@github-actions github-actions bot added the invalid The bug/issue caused by minor mistakes. label Feb 24, 2024
Update text color
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@1chooo 1chooo changed the title Update index.js Update AWS theme Feb 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some themes are invalid. See the Automated Theme Preview comment above for more information.

@github-actions github-actions bot removed the invalid The bug/issue caused by minor mistakes. label Feb 26, 2024
@1chooo
Copy link
Author

1chooo commented Feb 26, 2024

Hi @anuraghazra , @qwerty541

This PRs is approved now, could you help me review this? Thanks a lot!

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @1chooo! Thanks for your interest in our project. I'm closing this pull request because our team recently made a decision to stop addition of new themes to prevent bloating its collection and decrease maintenance efforts (see #3404). Maybe in future we will move themes into separate themes-provider project and you're welcome to contribute then. Currently you can use card customization options, I will add an example below.

<img src="https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true&title_color=e47911&text_color=f5f5f5&icon_color=e47911&border_color=B9EDC3&bg_color=232f3e" />

@qwerty541 qwerty541 closed this Feb 28, 2024
@1chooo 1chooo deleted the patch-1 branch May 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants