Added card_width argument to gist card
#3405
Conversation
|
@yaten2302 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @qwerty541, @rickstaa, could you please review and merge my PR under hacktoberfest. |
There was a problem hiding this comment.
@yaten2302 thanks for your pull request! Your pull request looks good 🚀. There however are some things that need to be resolved:
- The new parameter has to be documented under the Gist card exclusive options.
- Tests need to be added.
- Logic needs to be added so that the width gets clamped at a minimum width.
It would be great if you could fix these issues so that we can merge your PR in the main branch. For now I attached the hacktoberfest-accepted label since your pull request adheres to all Hacktoberfest requirements.
|
Thanks for the review @rickstaa, I'll make the changes ASAP👍 |
Added `MIN_CARD_WIDTH` to prevent the card from becoming too small.
|
Hi @rickstaa, made the changes, please review 👍 |
Hey, @yaten2302 are you sure you pushed the changes to the remote? I can't find the changes on GitHub 🤔. |
|
|
@yaten2302 I also requested these changes (I.e. documentation and tests). Sorry for being unclear 😅. Please let me know if you have any questions. |
|
@rickstaa, sorry, I forgot to make the changes in the tests and in documentation. And also, there I'm facing some issues in committing and pushing the changes, I will have to close this PR and create a new one. Sorry for inconvenience 🙏 |
No problem feel free to let me know when you created the new pull request 👍🏻. |
fixes #3370
This PR adds a new argument (
card_width) to thegist-card, which allows the user to adjust the width of the card.