Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gist card card_width argument #3370

Open
rickstaa opened this issue Oct 16, 2023 · 5 comments
Open

Add gist card card_width argument #3370

rickstaa opened this issue Oct 16, 2023 · 5 comments
Labels
enhancement New feature or request. hacktoberfest

Comments

@rickstaa
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We currently do not provide a way to set the card with the gist card while this option is available for the stats and language card.

Describe the solution you'd like

Adding the card_width argument to the gist card endpoint would be nice.

Describe alternatives you've considered

No response

Additional context

When this feature has been implemented and #3359 has been merged the card_width option can be moved to the https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#common-options.

@rickstaa rickstaa added the enhancement New feature or request. label Oct 16, 2023
@rickstaa rickstaa changed the title Add gist card card_width argument Add gist card card_width argument Oct 16, 2023
@Mohammad-Shahid-07
Copy link

can this issue be assigned to me?

@rickstaa
Copy link
Collaborator Author

can this issue be assigned to me?

Hey @Mohammad-Shahid-07, It is fantastic that you want to contribute to our projects. I assigned you! You can find the changes needed in ##3359, which adds the same feature to the repo card 👍🏻. I am looking forward to your pull request.

@rickstaa
Copy link
Collaborator Author

@Mohammad-Shahid-07 It looks like @yaten2302 already implemented this feature. As It looks like you haven't yet started working on it, I will accept #3405 as an entry.

@Mohammad-Shahid-07
Copy link

Mohammad-Shahid-07 commented Oct 30, 2023 via email

@rickstaa
Copy link
Collaborator Author

Sorry this was my first every try and I couldn't understand what to do and i got confused as the same was showing as closed from the link that was given there. Thank you very much for giving me the opportunity.

On Mon, 30 Oct 2023, 3:52 pm Rick Staa, @.> wrote: @Mohammad-Shahid-07 https://github.com/Mohammad-Shahid-07 It looks like @yaten2302 https://github.com/yaten2302 already implemented this feature. As It looks like you haven't yet started working on it, I will accept #3405 <#3405> as an entry. — Reply to this email directly, view it on GitHub <#3370 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2YIU47TCV2WH3IBMB6PNZDYB55X3AVCNFSM6AAAAAA6CEGQ66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUHA4DMOBWGE . You are receiving this because you were mentioned.Message ID: @.>

No problem at all. I can fully understand. The codebase became quite big after all those years 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants