[WIP] Migrate ovsdb client library #6176
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate from github.com/TomCodeLV/OVSDB-golang-lib/pkg/ovsdb to github.com/ovn-org/libovsdb for ovsdb interactions. Signed-off-by: Daman Arora <[email protected]>
|
Tried using the High-level API/ORM from |
antoninbas
reviewed
Apr 1, 2024
|
|
||
| // Port defines an object in Port table | ||
| type Port struct { |
There was a problem hiding this comment.
Can we keep the current model and only include the fields that we actually need?
Some fields may be required but I am pretty sure not all fields are required.
When I was working antrea-io/ofnet#76, I only had a subset of fields for the bridge table.
There was a problem hiding this comment.
yes, I just used the schema generated by model-gen to experiment with the flow. Will also configure monitor options for selected fields only rather than the complete table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from github.com/TomCodeLV/OVSDB-golang-lib/pkg/ovsdb to github.com/ovn-org/libovsdb for ovsdb interactions.
fixes: #5635