Additional trimming and padding options #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenfoxx
commented
Sep 16, 2023
Comment on lines
+3555
to
-3458
| var lblContact = dialog.add("group", undefined , {name: "lblContact"}); | ||
| lblContact.getText = function() { var t=[]; for ( var n=0; n<lblContact.children.length; n++ ) { var text = lblContact.children[n].text || ''; if ( text === '' ) text = ' '; t.push( text ); } return t.join('\n'); }; | ||
| lblContact.orientation = "column"; | ||
| lblContact.alignChildren = ["center","center"]; | ||
| lblContact.spacing = 0; | ||
|
|
||
| lblContact.add("statictext", undefined, "To get the most recent version, or leave feedback, go to:", {name: "lblContact"}); | ||
| lblContact.add("statictext", undefined, "https://github.com/antipalindrome/Photoshop-Export-Layers-to-Files-Fast", {name: "lblContact"}); |
There was a problem hiding this comment.
I'm not sure why this changed when importing the updated UI.
aidenfoxx
commented
Sep 16, 2023
aidenfoxx
commented
Sep 16, 2023
| @@ -1361,7 +1422,7 @@ function showDialog() { | |||
| fields.txtScale.onChange = function() { | |||
| var scaleNum = parseInt(this.text, 10); | |||
| if (isNaN(scaleNum)) { | |||
| scaleNum = prefs.paddingValue; | |||
| scaleNum = prefs.scaleValue; | |||
There was a problem hiding this comment.
I assume this was previously a copypasta mistake?
aidenfoxx
commented
Sep 16, 2023
…op-Export-Layers-to-Files-Fast into aidenfoxx/trim-options
aidenfoxx
commented
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to:
The impetus for the change was to enable better exporting of game assets such as text, where the height may need to remain the same, but the width should be constrained to the content.
Type of change