Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert locked React version #48674

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"format": "biome format --write .",
"install-react-16": "npm i --no-save --legacy-peer-deps react@16 react-dom@16 @testing-library/react@12",
"install-react-17": "npm i --no-save --legacy-peer-deps react@17 react-dom@17 @testing-library/react@12",
"install-react-18": "npm i --no-save --legacy-peer-deps react@18.2 react-dom@18.2",
"install-react-18": "npm i --no-save --legacy-peer-deps react@18 react-dom@18",
"prelint": "dumi setup",
"lint": "npm run version && npm run tsc && npm run lint:script && npm run lint:demo && npm run lint:md && npm run lint:style && npm run lint:changelog",
"lint-fix": "npm run lint-fix:script && npm run lint-fix:demo",
Expand Down
7 changes: 4 additions & 3 deletions tests/shared/excludeWarning.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
const originError = console.error;

export function isSafeWarning(message: boolean, all = false) {
const list = ['useLayoutEffect does nothing on the server'];

const list = [
'useLayoutEffect does nothing on the server',
'findDOMNode is deprecated and will be removed',
];
if (all) {
list.push('is deprecated in StrictMode');
}

return list.some((msg) => String(message).includes(msg));
}

Expand Down