feat(notification): add show progress option and update docs #48353
Conversation
|
|
|
|
👁 Visual Regression Report for PR #48353 Failed ❌
Check Full Report for details |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
yociduo
force-pushed
the
feat/notification-progress-bar
branch
from
1cb2dcd
to
e3751cd
Compare
|
the preview here https://preview-48353-ant-design.surge.sh/components/notification#notification-demo-show-progress doesn't show any progress indicator |
Yes, it's work in progress. I'm waiting for the dependence merged. The demo for rc-notification https://notification-git-fork-yociduo-feat-show-progess-react-component.vercel.app/demo/hooks |
|
可以参考这个设计 |
yociduo
force-pushed
the
feat/notification-progress-bar
branch
from
e3751cd
to
e53f010
Compare
|
yociduo
changed the title
@yociduo lint 报错了，需要处理一下
|
修复了，不过需要先处理组件那边的更新。 |
我去催一下 rc-notification 那边 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48353 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 746 746
Lines 13014 13014
Branches 3428 3428
=========================================
Hits 13014 13014 ☔ View full report in Codecov by Sentry. |
Co-authored-by: kiner-tang <[email protected]> Signed-off-by: Eden Wang <[email protected]>
|
@SocketSecurity ignore npm/@ant-design/[email protected] |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #48125
react-component/notification#322
💡 Background and solution
📝 Changelog
showProgresspropshowProgress属性☑️ Self-Check before Merge