Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ConfigProvider card bordered #47818

Open
wants to merge 2 commits into
base: feature
Choose a base branch
from

Conversation

yee94
Copy link
Contributor

@yee94 yee94 commented Mar 11, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Card 组件的 bordered 是由 Props 进行控制,部分设计规范中,对于 Card 是不需要 border 的,为了满足此类需求,需要在 ConfigProvider 中添加全局控制。对已有使用场景不受影响。

📝 Changelog

Language Changelog
🇺🇸 English Support card bordered config in ConfigProvider
🇨🇳 Chinese Config Provider中支持卡边框配置

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Mar 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 11, 2024

Preview failed

Copy link
Contributor

github-actions bot commented Mar 11, 2024

👁 Visual Regression Report for PR #47818 Passed ✅

🎯 Target branch: feature (5f1ac6c)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5f1ac6c) to head (eeeac8c).

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          736       736           
  Lines        12638     12639    +1     
  Branches      3324      3325    +1     
=========================================
+ Hits         12638     12639    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant