feat: spin support three level backgound opacity #47778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #47778 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47778 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 736 736
Lines 12638 12639 +1
Branches 3324 3324
=========================================
+ Hits 12638 12639 +1 ☔ View full report in Codecov by Sentry. |
|
效果不错 👍。新功能需要往 feature 分支合并，并且是 minor 版本。 markdown 选中语法 |
zombieJ
reviewed
Mar 11, 2024
components/spin/index.tsx
Outdated
|
|
||
| const SpinVisibilityies = ['soft', 'default', 'heavy'] as const; | ||
| export type SpinVisibility = (typeof SpinVisibilityies)[number]; | ||
| const SpinVisibilityOpacity: Record<SpinVisibility, number> = { |
There was a problem hiding this comment.
这个不符合设计规范，建议是通过 Design Token 来实现并提供例子。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
目前设定的 spin 组件背景模糊度在有些业务场景下不满足，因此增加了支持。
效果在这里
💡 需求背景和解决方案
📝 更新日志
☑️ 请求合并前的自查清单