Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): css variables for border and padding #6583

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Mar 29, 2024

CSS 变量

属性 说明 默认值 全局变量
--border-radius 圆角大小 8px --adm-card-border-radius
--padding-inline 水平内边距 12px --adm-card-padding-inline
--header-border-width header 分割线宽度 0.5px --adm-card-header-border-width
--header-border-color header 分割线颜色 var(--adm-color-border) --adm-card-header-border-color
--header-padding-block header 垂直内边距 12px --adm-card-header-padding-block
--body-padding-block body 垂直内边距 12px --adm-card-body-padding-block

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Size Change: +113 B (+0.03%)

Total Size: 352 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 189 kB +58 B (+0.03%)
./lib/bundle/style.css 18 kB +55 B (+0.31%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/antd-mobile.umd.js 144 kB
./lib/bundle/css-vars-patch.css 1.43 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Mar 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 102 KB 2.1 s (0%) 1.1 s (+4.19% 🔺) 3.2 s

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6583.surge.sh

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (cf550e4) to head (073def4).
Report is 14 commits behind head on master.

Current head 073def4 differs from pull request most recent head 16a3f5b

Please upload reports for the commit 16a3f5b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6583      +/-   ##
==========================================
- Coverage   92.34%   92.28%   -0.06%     
==========================================
  Files         318      318              
  Lines        6910     6962      +52     
  Branches     1729     1754      +25     
==========================================
+ Hits         6381     6425      +44     
- Misses        493      499       +6     
- Partials       36       38       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guoyunhe guoyunhe force-pushed the card-css-vars branch 2 times, most recently from bae02c3 to 7224ed8 Compare June 3, 2024 08:12
zombieJ
zombieJ previously approved these changes Jun 4, 2024
@zombieJ
Copy link
Member

zombieJ commented Jun 4, 2024

哦,等等。css var 可能还要一个 card.patch.less

@zombieJ zombieJ merged commit 1e21905 into master Jun 5, 2024
8 checks passed
@zombieJ zombieJ deleted the card-css-vars branch June 5, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants