Playbook Generation ThumbsUp/Down UI fix #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
approved these changes
May 22, 2024
TamiTakamiya
force-pushed
the
TamiTakamiya/playbook-generation-thumbupdown-ui
branch
from
457fdd2
to
716a66f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses to fix following two problems:
are displayed.
2. Thumbs Up or Thumbs/Down button s for one summary result can be clicked more than one time.
For 1, I removed the message issued from
extension.ts.For 2, I added a logic to disable Thumbs Up/Down buttons after one was clicked. If the user clicks the Back button and re-issue the outline API, these buttons are enabled again.
Attached screenshot shows how the disabled buttons look on the UI: