Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos to test matrix #4100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cristianonicolai
Copy link
Contributor

No description provided.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install docker on macos, look at vscode-ansible workflows to learn how to do it or you can add some code inside test_docker to not do any testing on mac.

Do not skip the test because PYTEST_REQPASS will cause the execution to fail if the number of passed test would be differnt. So keep in mind to modify the inside of the test.

Optimal is to enable docker, but the other option is also ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants