Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add request serializer for DAB create views #906

Merged
merged 2 commits into from
May 20, 2024

Conversation

Dostonbek1
Copy link
Member

@Dostonbek1 Dostonbek1 commented May 15, 2024

  • add a custom create serializer for viewsets imported from DAB RBAC in order to fix issues in test suite with openapi generator
  • update DAB version to 2024.5.18

JIRA: AAP-23971

@Dostonbek1 Dostonbek1 marked this pull request as ready for review May 16, 2024 19:50
@Dostonbek1 Dostonbek1 requested a review from a team as a code owner May 16, 2024 19:50
@Dostonbek1 Dostonbek1 changed the title [WIP] fix: add request serializer for DAB create views fix: add request serializer for DAB create views May 16, 2024
mkanoor
mkanoor previously approved these changes May 17, 2024
Alex-Izquierdo
Alex-Izquierdo previously approved these changes May 17, 2024
@Dostonbek1
Copy link
Member Author

Holding off on merging this PR until we get a new release of DAB with a fix for the failing e2e test.

@Dostonbek1 Dostonbek1 changed the title fix: add request serializer for DAB create views [ON HOLD] fix: add request serializer for DAB create views May 17, 2024
@Dostonbek1 Dostonbek1 dismissed stale reviews from Alex-Izquierdo and mkanoor via 74ab87e May 18, 2024 03:00
@Dostonbek1 Dostonbek1 changed the title [ON HOLD] fix: add request serializer for DAB create views fix: add request serializer for DAB create views May 18, 2024
@Dostonbek1
Copy link
Member Author

Updated to a DAB version that has a fix for the failing e2e test, verified locally as well. Once we get approval from reviewers, we should go ahead and merge this PR.

Copy link
Contributor

@dhaustein dhaustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Izquierdo Alex-Izquierdo merged commit 2ff98a9 into ansible:main May 20, 2024
4 checks passed
jshimkus-rh pushed a commit to jshimkus-rh/eda-server that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants