[Low Prio] add debug_timer decorator and other logs to auth.py

[kdelee]

@john-westcott-iv lmk if this is harmless enough to include

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[AlanCoding]

It would be better to refactor this code into a method and them apply the decorator the same as elsewhere.

[AlanCoding]

My quick 2 cents, following the DAB philosophy.

The promise of DAB is to standardize things. Having a one-off utility method like debug_timer is fine in other libraries, and is fine if there's a valid case that the utility will not be encountered again soon. But here is a method in AWX which does what that does with bells & whistles:

https://github.com/ansible/awx/blob/4754819a0916cbd9352550fb0f8fbc65273854b0/awx/main/utils/common.py#L1197-L1225

So I want to make the case here that we already have a widely shared need established.

That established, the (1)st change I'd seek is putting this into proper ansible_base/lib. But I would go further, the (2)nd change I'd like to see is setting us up to delete log_excess_runtime in AWX.

I don't love everything about that method. I'd suggest that long-term it would be better to use a local logger (starting with ansible_base.lib) as opposed to passing in a logger in my prior implementation. This would allow us to have special policies for performance logs from ansible_base in the logger configuration. Anything else you want to change about its feature set, please have a shot at it.

[john-westcott-iv]

I agree with Alan on this. Personally I can't decide if it should be ansible_base.lib.decerators or ansible_base.lib.performance. I kind of like the idea of performace because then you would end up with a logger like ansible_base.lib.performance and anything else you put in there would use that same logger. @kdelee if you don't have the time to dedicate to this now please cut a JIRA and we can do this as part of 2.5-next.

[john-westcott-iv]

@kdelee do you have capacity to make the requested changes?