Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django logout redirects #15148

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

manstis
Copy link
Contributor

@manstis manstis commented Apr 26, 2024

SUMMARY

This PR allows specification of Django's auth_views.LogoutView.success_url_allowed_hosts from settings.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
AWX VERSION
awx: 24.3.1.dev9+g4d163c3330
ADDITIONAL INFORMATION

This has been discussed on #aap-controller on Slack.

I managed to step through the code with sdb to check the settings change has no ill affect.

This PR will need an accompanying PR for awx-controller to be able to set the new environment variable from then operator.

This part of the code-base seems sparse of unit tests.. IDK if you require some?

@manstis
Copy link
Contributor Author

manstis commented Apr 26, 2024

I probably don't even need to change awx-operator as we can set the new environment variable as an extra_setting unless you want to make the new environment variable more public (e.g. include in the CRD/CSV as an explicit parameter)..

@thedoubl3j thedoubl3j changed the title AAP-23125: Support Django logout redirects Support Django logout redirects Apr 26, 2024
@manstis manstis force-pushed the AAP-23125 branch 2 times, most recently from f48738e to f587d2c Compare May 7, 2024 14:29
@manstis manstis force-pushed the AAP-23125 branch 3 times, most recently from d91f847 to 01ae1a5 Compare May 12, 2024 06:19
@manstis manstis closed this May 13, 2024
@manstis manstis reopened this May 13, 2024
@manstis manstis closed this May 13, 2024
@manstis manstis reopened this May 13, 2024
@rooftopcellist rooftopcellist merged commit 4d641b6 into ansible:devel May 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants