Add support for horizontal pod autoscaling #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanislav-zaprudskiy you might be interested in this |
kdelee
reviewed
Jan 19, 2024
|
Patch looks good to me. Most users of awx are probably not deploying constantly so keeping a bunch of web or task pods running does not make sense. It makes sense only when they are used. In theory with this the community can collectively save big on vCPU requested bloats that site idle for the majority of time. |
|
This would really help me out. We run a lot of jobs on schedule at particular after hours times so increasing the resources available dynamically is really needed |
TheRealHaoLiu
approved these changes
May 20, 2024
|
@dhageman PR looks great, can you rebase and we can get it in |
rcarrillocruz
approved these changes
Jun 3, 2024
rooftopcellist
approved these changes
Jun 3, 2024
|
@dhageman can you give this a rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allows the operator to create horizontal pod autoscaling resources for the web and task deployments.
It does not provide guidance on how to configure the HPA as those details are very cluster and use case specific.
ISSUE TYPE
ADDITIONAL INFORMATION
This code does not change the default behavior of the operator. A horizontal pod autoscaler will not be created unless it is specifically configured.
The minimum configuration required is to set the option
task_max_replicasorweb_max_replicasto be an integer greater thantask_replicasorweb_replicasrespecitively. This should create a HPA using the default values for a HPA which on OpenShift monitors CPU consumption.A good configuration for HPA will require requests, limits, and health probes for the the web and task pods to be implemented.